Fix the error message for #![feature(no_coverage)]
#115832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
Zalathar
commented
Sep 14, 2023
There was a problem hiding this comment.
The message for #[coverage(off)] down below was already good; the only problem was the message for #![feature(no_coverage)]).
|
@bors r+ rollup whoops, good catch |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 14, 2023
Fix the error message for `#![feature(no_coverage)]` When rust-lang#114656 was written, the feature flag to replace `no_coverage` was originally spelled `coverage`, but it was eventually changed to `coverage_attribute` instead. That update happened to miss this error message in `removed.rs`, and unfortunately I only noticed just *after* the original PR was approved and merged. cc `@bossmc` (original author) `@oli-obk` (original reviewer) `@rustbot` label +A-code-coverage
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#115772 (Improve Span in smir) - rust-lang#115832 (Fix the error message for `#![feature(no_coverage)]`) - rust-lang#115834 (Properly consider binder vars in `HasTypeFlagsVisitor`) - rust-lang#115844 (Paper over an accidental regression) r? `@ghost` `@rustbot` modify labels: rollup
|
Thanks @Zalathar! Good spot. |
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2023
Rollup merge of rust-lang#115832 - Zalathar:fix-no-coverage, r=oli-obk Fix the error message for `#![feature(no_coverage)]` When rust-lang#114656 was written, the feature flag to replace `no_coverage` was originally spelled `coverage`, but it was eventually changed to `coverage_attribute` instead. That update happened to miss this error message in `removed.rs`, and unfortunately I only noticed just *after* the original PR was approved and merged. cc ``@bossmc`` (original author) ``@oli-obk`` (original reviewer) ``@rustbot`` label +A-code-coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #114656 was written, the feature flag to replace
no_coveragewas originally spelledcoverage, but it was eventually changed tocoverage_attributeinstead.That update happened to miss this error message in
removed.rs, and unfortunately I only noticed just after the original PR was approved and merged.cc @bossmc (original author) @oli-obk (original reviewer)
@rustbot label +A-code-coverage