clippy::complexity fixes #116209
Closed
clippy::complexity fixes #116209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
match_single_binding needless_question_mark redundant_slicing derivable_impls filter_next
|
(rustbot has picked a reviewer for you, use r? to override) |
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
Comment on lines
+23
to
24
| .find(filter_array_elements(tcx, query.param_env)) | ||
| .is_some(); |
There was a problem hiding this comment.
Suggested change
| .find(filter_array_elements(tcx, query.param_env)) | |
| .is_some(); | |
| .any(filter_array_elements(tcx, query.param_env)); |
Comment on lines
+58
to
59
| .find(filter_array_elements(tcx, query.param_env)) | ||
| .is_some(); |
There was a problem hiding this comment.
Suggested change
| .find(filter_array_elements(tcx, query.param_env)) | |
| .is_some(); | |
| .any(filter_array_elements(tcx, query.param_env)); |
There was a problem hiding this comment.
error[E0277]: expected a `std::ops::FnMut<(Result<rustc_middle::ty::Ty<'tcx>, AlwaysRequiresDrop>,)>` closure, found `impl for<'a> Fn(&'a Result<rustc_middle::ty::Ty<'_>, AlwaysRequiresDrop>) -> bool`
--> compiler/rustc_ty_utils/src/needs_drop.rs:58:10
|
58 | .any(filter_array_elements(tcx, query.param_env));
| --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected an `FnMut<(Result<rustc_middle::ty::Ty<'tcx>, AlwaysRequiresDrop>,)>` closure, found `impl for<'a> Fn(&'a Result<rustc_middle::ty::Ty<'_>, AlwaysRequiresDrop>) -> bool`
| |
| required by a bound introduced by this call
|
= help: the trait `std::ops::FnMut<(Result<rustc_middle::ty::Ty<'tcx>, AlwaysRequiresDrop>,)>` is not implemented for `impl for<'a> Fn(&'a Result<rustc_middle::ty::Ty<'_>, AlwaysRequiresDrop>) -> bool`
= note: expected a closure with arguments `(&Result<rustc_middle::ty::Ty<'_>, AlwaysRequiresDrop>,)`
found a closure with arguments `(Result<rustc_middle::ty::Ty<'tcx>, AlwaysRequiresDrop>,)`
note: required by a bound in `std::iter::Iterator::any`
--> /home/matthias/vcs/github/rust/library/core/src/iter/traits/iterator.rs:2857:12
|
2854 | fn any<F>(&mut self, f: F) -> bool
| --- required by a bound in this associated function
...
2857 | F: FnMut(Self::Item) -> bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Iterator::any`
There was a problem hiding this comment.
You should be able to fix it by introducing a closure
There was a problem hiding this comment.
Actually, just edit the signature of filter_array_elements to take a Result<Ty<'tcx>, NeedsDrop> rather than a &Result<..>?
|
@rustbot author to address the comments above |
|
☔ The latest upstream changes (presumably #117692) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@matthiaskrgr any updates on this? thanks |
|
Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
match_single_binding
needless_question_mark
redundant_slicing
derivable_impls
filter_next