Skip to content

interpret: extend comment on the inhabitedness check in downcast #118935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2023
Merged

interpret: extend comment on the inhabitedness check in downcast #118935

merged 1 commit into from
Dec 14, 2023

Conversation

RalfJung
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 14, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 14, 2023

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
downloading https://ci-artifacts.rust-lang.org/rustc-builds-alt/d23e1a689426638a5146c204e09278433c509610/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
curl: (35) OpenSSL SSL_connect: Connection reset by peer in connection to ci-artifacts.rust-lang.org:443 
ERROR: failed to download llvm from ci

    HELP: old builds get deleted after a certain time
    HELP: if trying to compile an old commit of rustc, disable `download-ci-llvm` in config.toml:
    [llvm]
    download-ci-llvm = false
    
Build completed unsuccessfully in 0:00:00

@RalfJung
Copy link
Member Author

"ERROR: failed to download llvm from ci"

@saethlin
Copy link
Member

👍
@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Dec 14, 2023

📌 Commit 5d87d83 has been approved by saethlin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 14, 2023
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 14, 2023
@GuillaumeGomez
Rollup merge of rust-lang#118935 - RalfJung:interpret-downcast, r=sae…
a15f60d 
…thlin

interpret: extend comment on the inhabitedness check in downcast

Cc rust-lang#115145
r? `@saethlin`
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 14, 2023
@bors
Auto merge of rust-lang#118942 - GuillaumeGomez:rollup-n5vtatg, r=Gui…
11fcf9c 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#118770 (Fix cases where std accidentally relied on inline(never))
 - rust-lang#118910 ([rustdoc] Use Map instead of Object for source files and search index)
 - rust-lang#118914 (Unconditionally register alias-relate in projection goal)
 - rust-lang#118935 (interpret: extend comment on the inhabitedness check in downcast)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 14, 2023
@bors
Auto merge of rust-lang#118949 - matthiaskrgr:rollup-rdzlb9h, r=matth…
de686cb 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#118910 ([rustdoc] Use Map instead of Object for source files and search index)
 - rust-lang#118914 (Unconditionally register alias-relate in projection goal)
 - rust-lang#118935 (interpret: extend comment on the inhabitedness check in downcast)
 - rust-lang#118945 (rustc_codegen_ssa: Remove trailing spaces in Display impl for CguReuse)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 49a2fc2 into rust-lang:master Dec 14, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 14, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 14, 2023
@rust-timer
Unrolled build for rust-lang#118935
fe60dad 
Rollup merge of rust-lang#118935 - RalfJung:interpret-downcast, r=saethlin

interpret: extend comment on the inhabitedness check in downcast

Cc rust-lang#115145
r? ``@saethlin``
@RalfJung RalfJung deleted the interpret-downcast branch December 16, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@saethlin saethlin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rustbot @rust-log-analyzer @saethlin @bors