Skip to content

Conversation

fmease
Copy link
Member

@fmease fmease commented Jan 23, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

oberien and others added 23 commits December 16, 2023 23:44
The practical motivation is to omit the pass from -Zdump-mir=all when
disabled.
…vidtwco

Suggest array::from_fn for array initialization

Fixes rust-lang#119530
…specs, r=wesleywiser

compiler: update freebsd and netbsd base specs.

both support thread local.
Update some deps with `bitflags` v1 dependencies

This only leaves `pulldown-cmark` (which has updated to bitflags v2 in Git) and `rustc_apfloat` (PR opened previously at rust-lang/rustc_apfloat#12)
Use `Self` in `NonZero*` implementations.

This slightly reduces the size of the eventual diff when making these generic, since this can be merged independently.
…estebank

Re-add estebank to review rotation

r? ``@compiler-errors``
…-errors

rename `RawTy` to `LoweredTy`

I believe this name to more closely match its purpose

r? ``@compiler-errors``
A bunch of random modifications

r? oli-obk

Kitchen sink of changes that I didn't know where to put elsewhere. Documentation tweaks mostly, but also removing some unreachable code and simplifying the pretty printing for closures/coroutines.
Move condition enabling the pass to `is_enabled`

The practical motivation is to omit the pass from -Zdump-mir=all when disabled.
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) rollup A PR which is a rollup labels Jan 23, 2024
@fmease
Copy link
Member Author

fmease commented Jan 23, 2024

@bors r+ rollup=never p=10

@bors
Copy link
Collaborator

bors commented Jan 23, 2024

📌 Commit 08bac31 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2024
@bors
Copy link
Collaborator

bors commented Jan 23, 2024

⌛ Testing commit 08bac31 with merge 5d3d347...

@bors
Copy link
Collaborator

bors commented Jan 23, 2024

☀️ Test successful - checks-actions
Approved by: fmease
Pushing 5d3d347 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 23, 2024
@bors bors merged commit 5d3d347 into rust-lang:master Jan 23, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 23, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#119028 Add more weirdness to weird-exprs.rs b324b37c4825e038fd8746525964906dabfb3ab6 (link)
#119805 Suggest array::from_fn for array initialization f0c1c3f44ec07aa80f4663e887d3f4b37e4bf71d (link)
#120188 compiler: update freebsd and netbsd base specs. e57847bbfcd7976f9468c117b0b68b2a47242c40 (link)
#120215 Update some deps with bitflags v1 dependencies 209f1455f6dff6be772185a0903ed46922672ecf (link)
#120244 Use Self in NonZero* implementations. 77401ed238603772e6ef3324ba69bc31426d0433 (link)
#120246 Re-add estebank to review rotation 06f1a43a9ba1037eb2154fa1a7b9814f5b865f9c (link)
#120252 rename RawTy to LoweredTy c8aafb8378b83891481a0ff970bce9f8b8664365 (link)
#120255 correct my mailmap entry 17ef1e68a397108c0ee3bf2d923c6535c6a0dd84 (link)
#120270 A bunch of random modifications 231695f0bc4a263294494a8ae03fca5e121b64ba (link)
#120280 Move condition enabling the pass to is_enabled 92e5ec7d14d9dfb69591458a9683cb21e544e47f (link)

previous master: dfe53afaeb

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@fmease fmease deleted the rollup-9nxail8 branch January 23, 2024 22:45
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5d3d347): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.5% [-3.5%, -3.5%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
8.3% [6.5%, 10.5%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 662.823s -> 664.053s (0.19%)
Artifact size: 308.32 MiB -> 308.29 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.