Skip to content

Conversation

Bryanskiy
Copy link
Contributor

fixes #122874

Delegation item should be wrapped in a rib to behave like a regular function during name resolution.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2024
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 26, 2024

📌 Commit 17c6101 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2024
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#122766 (store segment and module in `UnresolvedImportError`)
 - rust-lang#122996 (simplify_branches: add comment)
 - rust-lang#123047 (triagebot: Add notification of 2024 issues)
 - rust-lang#123066 (CFI: (actually) check that methods are object-safe before projecting their receivers to `dyn Trait` in CFI)
 - rust-lang#123067 (match lowering: consistently merge simple or-patterns)
 - rust-lang#123069 (Revert `cargo update` changes and bump `download-artifact` to v4)
 - rust-lang#123070 (Add my former address to .mailmap)
 - rust-lang#123086 (Fix doc link to BufWriter in std::fs::File documentation)
 - rust-lang#123090 (Remove `CacheSelector` trait now that we can use GATs)
 - rust-lang#123091 (Delegation: fix ICE on wrong `self` resolution)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2024
Rollup merge of rust-lang#123091 - Bryanskiy:delegation-fixes, r=petrochenkov

Delegation: fix ICE on wrong `self` resolution

fixes rust-lang#122874

Delegation item should be wrapped in a `rib` to behave like a regular function during name resolution.

r? `@petrochenkov`
@bors bors merged commit 4d1fb9e into rust-lang:master Mar 26, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 26, 2024
@petrochenkov petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-fn_delegation `#![feature(fn_delegation)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE : Res::Err but no error emitted with fn_delegation
4 participants