OpenBSD fix long socket addresses #123779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as you did some reviewing in previous PR |
This comment has been minimized.
This comment has been minimized.
Original diff from @notgull in rust-lang#118349, small changes from me. on OpenBSD, getsockname(2) returns the actual size of the socket address, and not the len of the content. Figure out the length for ourselves. see https://marc.info/?l=openbsd-bugs&m=170105481926736&w=2 Fixes rust-lang#116523
bd96a36 to
7aaad6b
Compare
|
@bors r+ |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 14, 2024
…Mark-Simulacrum OpenBSD fix long socket addresses Original diff from `@notgull` in rust-lang#118349, small changes from me. on OpenBSD, getsockname(2) returns the actual size of the socket address, and not the len of the content. Figure out the length for ourselves. see https://marc.info/?l=openbsd-bugs&m=170105481926736&w=2 Fixes rust-lang#116523
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#123651 (Thread local updates for idiomatic examples) - rust-lang#123699 (run-make-support: tidy up support library) - rust-lang#123779 (OpenBSD fix long socket addresses) - rust-lang#123803 (Fix `VecDeque::shrink_to` UB when `handle_alloc_error` unwinds.) - rust-lang#123875 (Doc: replace x with y for hexa-decimal fmt) - rust-lang#123879 (Add missing `unsafe` to some internal `std` functions) - rust-lang#123889 (reduce tidy overheads in run-make checks) - rust-lang#123898 (Generic associated consts: Check regions earlier when comparing impl with trait item def) - rust-lang#123902 (compiletest: Update rustfix to 0.8.1) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#123651 (Thread local updates for idiomatic examples) - rust-lang#123699 (run-make-support: tidy up support library) - rust-lang#123779 (OpenBSD fix long socket addresses) - rust-lang#123875 (Doc: replace x with y for hexa-decimal fmt) - rust-lang#123879 (Add missing `unsafe` to some internal `std` functions) - rust-lang#123889 (reduce tidy overheads in run-make checks) - rust-lang#123898 (Generic associated consts: Check regions earlier when comparing impl with trait item def) - rust-lang#123902 (compiletest: Update rustfix to 0.8.1) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 14, 2024
Rollup merge of rust-lang#123779 - semarie:notgull-openbsd-socket, r=Mark-Simulacrum OpenBSD fix long socket addresses Original diff from ``@notgull`` in rust-lang#118349, small changes from me. on OpenBSD, getsockname(2) returns the actual size of the socket address, and not the len of the content. Figure out the length for ourselves. see https://marc.info/?l=openbsd-bugs&m=170105481926736&w=2 Fixes rust-lang#116523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original diff from @notgull in #118349, small changes from me.
on OpenBSD, getsockname(2) returns the actual size of the socket address, and not the len of the content. Figure out the length for ourselves. see https://marc.info/?l=openbsd-bugs&m=170105481926736&w=2
Fixes #116523