Skip to content

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Apr 24, 2024

Fixes #97006
Fixes #123911
Fixes #123912

This patch ensures that we no longer have to handle invalid generic arguments in attribute paths.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 24, 2024
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2024
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 10, 2024

📌 Commit f70f900 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
Rollup of 5 pull requests

Successful merges:

 - rust-lang#124233 (Add `-lmingwex` second time in `mingw_libs`)
 - rust-lang#124318 (ignore generics args in attribute paths)
 - rust-lang#124899 (bootstrap: add comments for the automatic dry run)
 - rust-lang#124904 (reachable computation: extend explanation of what this does, and why)
 - rust-lang#124930 (Make sure we consume a generic arg when checking mistyped turbofish)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 69122f1 into rust-lang:master May 11, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
Rollup merge of rust-lang#124318 - bvanjoi:fix-123911, r=petrochenkov

ignore generics args in attribute paths

Fixes rust-lang#97006
Fixes rust-lang#123911
Fixes rust-lang#123912

This patch ensures that we no longer have to handle invalid generic arguments in attribute paths.

r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE : no entry found for key ICE : non-eager expansion without a parent scope ICE: -Zunpretty=hir "AST generic args printed by HIR pretty-printer"
4 participants