Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Part of #121876.

This one adds a lot of utility methods/functions. To prevent having too much changes at once, I didn't make the existing rmake tests use these yet but I'll send a follow-up so they all use it.

r? @jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 11, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

@GuillaumeGomez GuillaumeGomez force-pushed the migrate-rustdoc-scrape-examples-ordering branch from df8c037 to 114e257 Compare May 12, 2024 09:30
@GuillaumeGomez
Copy link
Member Author

Removed a forgotten debug.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 12, 2024

📌 Commit 114e257 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2024
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#125021 (Update reference safety requirements)
 - rust-lang#125022 (Migrate rustdoc scrape examples ordering)
 - rust-lang#125030 (Fix some minor issues from the ui-test auto-porting)
 - rust-lang#125036 (solve: all "non-structural" logging to trace)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1393a87 into rust-lang:master May 12, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2024
Rollup merge of rust-lang#125022 - GuillaumeGomez:migrate-rustdoc-scrape-examples-ordering, r=jieyouxu

Migrate rustdoc scrape examples ordering

Part of rust-lang#121876.

This one adds a lot of utility methods/functions. To prevent having too much changes at once, I didn't make the existing rmake tests use these yet but I'll send a follow-up so they all use it.

r? `@jieyouxu`
@GuillaumeGomez GuillaumeGomez deleted the migrate-rustdoc-scrape-examples-ordering branch May 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants