Skip to content

remove read-only restriction on /checkout #127158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove read-only restriction on /checkout #127158

wants to merge 1 commit into from

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Jun 30, 2024 •
edited
Loading

Currently, we are setting read-only restrictions on /checkout path in containers, which conflicts with various bootstrap linking logic. This change removes this restriction.

For more context, see #122709 (comment) and #127151

@onur-ozkan
remove read-only restriction on /checkout
7ef7df0 
Currently, we are setting read-only restrictions on `/checkout` path in containers,
which conflicts with various bootstrap linking logic. This change removes this restriction.

Signed-off-by: onur-ozkan <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 30, 2024
@onur-ozkan
Copy link
Member Author

I am not sure how adding read-only restriction helps in containers. What is the reason behind it?

cc @rust-lang/infra

@bjorn3
Copy link
Member

bjorn3 commented Jun 30, 2024

The source directory should never be modified during a build. Only the build directory may be modified. I'm pretty sure several distros enforce this.

@onur-ozkan
Copy link
Member Author

The source directory should never be modified during a build. Only the build directory may be modified. I'm pretty sure several distros enforce this.

True.. I will check again and make sure not to copy things to /checkout when it is symlinked as this modifies the source directory.

@onur-ozkan onur-ozkan closed this Jun 30, 2024
@Kobzol
Copy link
Member

Kobzol commented Jun 30, 2024

It would be good to add this justification to the bash script.

@onur-ozkan
Copy link
Member Author

Hopefully #127188 should fix the problem.

@onur-ozkan onur-ozkan deleted the remove-ro-restriction branch June 30, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @rustbot @bjorn3 @Kobzol @Mark-Simulacrum