Skip to content

Update LLVM submodule #127364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2024
Merged

Update LLVM submodule #127364

merged 1 commit into from
Jul 6, 2024

Conversation

dianqk
Copy link
Member

@dianqk dianqk commented Jul 5, 2024

Fixes #127260. Fixes #127286.

r? @nikic

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2024
@nikic
Copy link
Contributor

nikic commented Jul 5, 2024

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 5, 2024

📌 Commit 3d699a4 has been approved by nikic

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2024
@bors
Copy link
Collaborator

bors commented Jul 6, 2024

⌛ Testing commit 3d699a4 with merge 5c08cc7...

@bors
Copy link
Collaborator

bors commented Jul 6, 2024

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 5c08cc7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 6, 2024
@bors bors merged commit 5c08cc7 into rust-lang:master Jul 6, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jul 6, 2024
@dianqk dianqk deleted the update-llvm branch July 6, 2024 03:58
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5c08cc7): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.5% [0.5%, 0.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.6%, secondary 1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.6% [2.2%, 3.0%] 2
Regressions ❌
(secondary)		 1.5% [0.4%, 2.5%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.6% [2.2%, 3.0%] 2

Cycles

Results (secondary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.5% [-0.5%, -0.4%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 698.167s -> 698.837s (0.10%)
Artifact size: 328.26 MiB -> 328.25 MiB (-0.00%)

@nikic nikic added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2024
@nikic
Copy link
Contributor

nikic commented Jul 6, 2024

Fixes P-high miscompile.

@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 11, 2024
@cuviper cuviper mentioned this pull request Jul 11, 2024
Merged
@cuviper cuviper modified the milestones: 1.81.0, 1.80.0 Jul 11, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 12, 2024
@bors
Auto merge of rust-lang#127618 - cuviper:beta-next, r=cuviper
b8b9158 
[beta] backports

- Update LLVM submodule rust-lang#127364
- instantiate higher ranked goals in candidate selection again rust-lang#127568

r? cuviper
@Veykril Veykril mentioned this pull request Aug 6, 2024
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Aug 7, 2024
@bors-ferrocene @dianqk
@RalfJung @Veykril
Merge #829
1967063 
829: Backport two soundness fixes to 1.79 r=pietroalbini a=Veykril

Backports:
- rust-lang/rust#127364
- rust-lang/rust#126154

Co-authored-by: DianQK <[email protected]>
Co-authored-by: Ralf Jung <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Aug 8, 2024
@bors-ferrocene @dianqk
@RalfJung @Veykril
Merge #829
21ef029 
829: Backport two soundness fixes to 1.79 r=pietroalbini a=Veykril

Backports:
- rust-lang/rust#127364
- rust-lang/rust#126154

Co-authored-by: DianQK <[email protected]>
Co-authored-by: Ralf Jung <[email protected]>
Co-authored-by: Lukas Wirth <[email protected]>
@Veykril Veykril mentioned this pull request Aug 13, 2024
Merged
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Aug 13, 2024
@bors-ferrocene @Veykril
Merge #838
fc5bce3 
838: Add tests for backports r=skade a=Veykril

- `tests/ui/ferrocene/llvm/no-segfault.rs` tests [issue#127260](rust-lang/rust#127260) which was fixed by the backported [PR#127364](rust-lang/rust#127364) 
- `tests/ui/ferrocene/consts/storage-live-on-live.rs` tests [issue#119366](rust-lang/rust#119366) which was fixed by the backported [PR#126154](rust-lang/rust#126154)
- `tests/codegen/ferrocene/miscompile_127286.rs` tests [issue#127286](rust-lang/rust#127286) which was fixed by the backported [PR#127364](rust-lang/rust#127364) 

Co-authored-by: Lukas Wirth <[email protected]>
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Aug 13, 2024
@bors-ferrocene @Veykril
Merge #838
94bd7e1 
838: Add tests for backports r=skade a=Veykril

- `tests/ui/ferrocene/llvm/no-segfault.rs` tests [issue#127260](rust-lang/rust#127260) which was fixed by the backported [PR#127364](rust-lang/rust#127364) 
- `tests/ui/ferrocene/consts/storage-live-on-live.rs` tests [issue#119366](rust-lang/rust#119366) which was fixed by the backported [PR#126154](rust-lang/rust#126154)
- `tests/codegen/ferrocene/miscompile_127286.rs` tests [issue#127286](rust-lang/rust#127286) which was fixed by the backported [PR#127364](rust-lang/rust#127364) 

Co-authored-by: Lukas Wirth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikic nikic

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
7 participants
@dianqk @rustbot @nikic @bors @rust-timer @apiraino @cuviper