Mark missing_fragment_specifier as FutureReleaseErrorReportInDeps
#128122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if there is more that I need to change within the compiler. Waiting on my local to complete tests. |
|
I would hope that nothing in the compiler's transitive dependencies relies on this behavior. No harm in kicking off bors in the mean time -- tests don't need to pass, for the record. @bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 24, 2024
…unconditional, r=<try> [do not merge] crater: missing fragment specifier FutureReleaseErrorReportInDeps Test making missing fragment specifiers a deny by default error. See rust-lang#128006 r? `@petrochenkov`
|
I think I might have misunderstood #128006 (comment). Is petrochenkov suggesting that we can use the output of changing to |
|
Or more accurate question, will crates with |
This. |
|
r=me after updating commit/PR titles/descriptions. |
798d579 to
b5425f5
Compare
missing_fragment_specifier as FutureReleaseErrorReportInDeps
We are moving toward forbidding `missing_fragment_specifier` either in edition 2024 or unconditionally. Make a first step toward this by ensuring crates that rely on the old behavior are reported when used as dependencies. Tracking issue: <rust-lang#128143>
b5425f5 to
c9886a1
Compare
|
Squashed and reworded the commit, as well as adjusted the PR info. Thanks for the review. @bors r=petrochenkov |
3 tasks
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 24, 2024
…r-unconditional, r=petrochenkov Mark `missing_fragment_specifier` as `FutureReleaseErrorReportInDeps` We are moving toward forbidding `missing_fragment_specifier` either in edition 2024 or unconditionally. Make a first step toward this by ensuring crates that rely on the old behavior are reported when used as dependencies. Tracking issue: <rust-lang#128143>
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 24, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#126548 (Improved clarity of documentation for std::fs::create_dir_all) - rust-lang#127528 (Replace ASCII control chars with Unicode Control Pictures) - rust-lang#127717 (Fix malformed suggestion for repeated maybe unsized bounds) - rust-lang#128046 (Fix some `#[cfg_attr(not(doc), repr(..))]`) - rust-lang#128122 (Mark `missing_fragment_specifier` as `FutureReleaseErrorReportInDeps`) - rust-lang#128135 (std: use duplicate thread local state in tests) - rust-lang#128140 (Remove Unnecessary `.as_str()` Conversions) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 24, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#122192 (Do not try to reveal hidden types when trying to prove auto-traits in the defining scope) - rust-lang#126042 (Implement `unsigned_signed_diff`) - rust-lang#126548 (Improved clarity of documentation for std::fs::create_dir_all) - rust-lang#127717 (Fix malformed suggestion for repeated maybe unsized bounds) - rust-lang#128046 (Fix some `#[cfg_attr(not(doc), repr(..))]`) - rust-lang#128122 (Mark `missing_fragment_specifier` as `FutureReleaseErrorReportInDeps`) - rust-lang#128135 (std: use duplicate thread local state in tests) - rust-lang#128140 (Remove Unnecessary `.as_str()` Conversions) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2024
Rollup merge of rust-lang#128122 - tgross35:missing-fragment-specifier-unconditional, r=petrochenkov Mark `missing_fragment_specifier` as `FutureReleaseErrorReportInDeps` We are moving toward forbidding `missing_fragment_specifier` either in edition 2024 or unconditionally. Make a first step toward this by ensuring crates that rely on the old behavior are reported when used as dependencies. Tracking issue: <rust-lang#128143>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving toward forbidding
missing_fragment_specifiereither in edition 2024 or unconditionally. Make a first step toward this by ensuring crates that rely on the old behavior are reported when used as dependencies.Tracking issue: #128143
r? @petrochenkov