Skip to content

Add myself back to review rotation #131484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

Add myself back to review rotation #131484

merged 1 commit into from
Oct 10, 2024

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Oct 10, 2024

No description provided.

@jhpratt jhpratt added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Oct 10, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Oct 10, 2024 •
edited
Loading

@bors r+ rollup (you can self-approve such PRs)

@bors
Copy link
Collaborator

bors commented Oct 10, 2024

📌 Commit e481599 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2024
@jhpratt
Copy link
Member Author

jhpratt commented Oct 10, 2024

Ah, I didn't think bors would let me self-approve any PR.

@matthiaskrgr matthiaskrgr mentioned this pull request Oct 10, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
@bors
Auto merge of rust-lang#131495 - matthiaskrgr:rollup-lwf2u4i, r=matth…
4cc494b 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#130625 (Fix a few relative paths in rustc doc)
 - rust-lang#131397 (fix/update teach_note from 'escaping mutable ref/ptr' const-check)
 - rust-lang#131479 (Apple: Avoid redundant `-Wl,-dylib` flag when linking)
 - rust-lang#131480 (Fix hardcoded strip path when cross-compiling from Linux to Darwin)
 - rust-lang#131482 (structurally resolve adts and tuples expectations too)
 - rust-lang#131484 (Add myself back to review rotation)
 - rust-lang#131491 (impossible obligations fast path)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7eb5621 into rust-lang:master Oct 10, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 10, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2024
@rust-timer
Unrolled build for rust-lang#131484
1b7fbf5 
Rollup merge of rust-lang#131484 - jhpratt:review-rotation, r=jieyouxu

Add myself back to review rotation
@jhpratt jhpratt deleted the review-rotation branch October 13, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jhpratt @rustbot @jieyouxu @bors @Mark-Simulacrum