Special case error message for a build-fail test that failed check build
#131642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
r? bootstrap (Mark has a ton of assigned PRs) |
|
cc @RalfJung and @asquared31415 does this error message make more sense to you? |
That sounds great :) |
|
@bors r+ |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#131086 (Update unicode-width to 0.2.0) - rust-lang#131585 (compiletest: Remove the one thing that was checking a directive's `original_line`) - rust-lang#131614 (Error on trying to use revisions in `run-make` tests) - rust-lang#131638 (compiletest: Move debugger setup code out of `lib.rs`) - rust-lang#131641 (switch unicode-data bitsets back to 'static') - rust-lang#131642 (Special case error message for a `build-fail` test that failed check build) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2024
Rollup merge of rust-lang#131642 - jieyouxu:build-fail-check-fail, r=Kobzol Special case error message for a `build-fail` test that failed check build A `build-fail` test requires that a check build (roughly `--emit=metadata`, no codegen) succeeds but fails later. Previously, if its check build failed, the user will see the error message ``` error: test compilation failed although it shouldn't! ``` which is confusing. Because the test is `build-fail`, we want the test compilation to fail! This error message doesn't account for the difference between a check build and a complete build, so let's special case the error message for a `build-fail` test whose check build failed to instead say ``` error: `build-fail` test is required to pass check build, but check build failed ``` Fixes rust-lang#130894.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
build-failtest requires that a check build (roughly--emit=metadata, no codegen) succeeds but fails later. Previously, if its check build failed, the user will see the error messagewhich is confusing. Because the test is
build-fail, we want the test compilation to fail! This error message doesn't account for the difference between a check build and a complete build, so let's special case the error message for abuild-failtest whose check build failed to instead sayFixes #130894.