Use Enabled{Lang,Lib}Feature instead of n-tuples
#132114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
|
UI tests passed locally so @rustbot ready |
RalfJung
reviewed
Oct 24, 2024
Instead of passing around random n-tuples of e.g. `(gate_name, attr_sp, since)`.
4ab1126 to
3528149
Compare
EnabledLangFeature, EnabledLibFeature and LangFeatureStability instead of n-tuples/Option<Symbol>Enabled{Lang,Lib}Feature instead of n-tuples
|
@rustbot ready |
|
@bors r+ rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#132114 (Use `Enabled{Lang,Lib}Feature` instead of n-tuples) - rust-lang#132163 (Update Fuchsia CI script for package serving) - rust-lang#132168 (Effects cleanup) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2024
Rollup merge of rust-lang#132114 - jieyouxu:features-bundle, r=fee1-dead Use `Enabled{Lang,Lib}Feature` instead of n-tuples Instead of passing around e.g. `(gate_name, attr_span, stable_since)` 3-tuples for enabled lang features or `(gate_name, attr_span)` 2-tuples for enabled lib features, use `Enabled{Lang,Lib}Feature` structs with named fields. Also did some minor code-golfing of involved iterator chains to hopefully make them easier to follow. Follow-up to rust-lang#132098 (comment) cc `@RalfJung.`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing around e.g.
(gate_name, attr_span, stable_since)3-tuples for enabled lang features or(gate_name, attr_span)2-tuples for enabled lib features, useEnabled{Lang,Lib}Featurestructs with named fields.Also did some minor code-golfing of involved iterator chains to hopefully make them easier to follow.
Follow-up to #132098 (comment) cc @RalfJung.