Skip to content

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Nov 23, 2024

anchor returns impl Display, so no need to call to_string().

@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2024

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 23, 2024
@aDotInTheVoid
Copy link
Member

r? @aDotInTheVoid

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 23, 2024

📌 Commit da4c050 has been approved by aDotInTheVoid

It is now in the queue for this repository.

@rustbot rustbot assigned aDotInTheVoid and unassigned notriddle Nov 23, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2024
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#133300 (inject_panic_runtime(): Avoid double negation for 'any non rlib')
 - rust-lang#133301 (Add code example for `wrapping_neg` method for signed integers)
 - rust-lang#133371 (remove is_trivially_const_drop)
 - rust-lang#133389 (Stabilize `const_float_methods`)
 - rust-lang#133398 (rustdoc: do not call to_string, it's already impl Display)
 - rust-lang#133405 (tidy: Distinguish between two different meanings of "style file")

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e87e205 into rust-lang:master Nov 24, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Nov 24, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2024
Rollup merge of rust-lang#133398 - klensy:rd-to-string, r=aDotInTheVoid

rustdoc: do not call to_string, it's already impl Display

`anchor` returns impl Display, so no need to call to_string().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants