Fix ProvenVia for global where clauses
#138797
Merged
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? lcnr |
lcnr
reviewed
Mar 26, 2025
995cb2f to
2752dad
Compare
2752dad to
89d0e7c
Compare
|
@bors r=lcnr rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2025
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#136877 (Fix missing const for inherent pointer `replace` methods) - rust-lang#138797 (Fix `ProvenVia` for global where clauses) - rust-lang#139121 (Rename internal module from `statik` to `no_threads`) - rust-lang#139319 (StableMIR: Prepare for refactoring) - rust-lang#139404 (Small smir cleanup) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2025
Rollup merge of rust-lang#138797 - compiler-errors:global-proven-via, r=lcnr Fix `ProvenVia` for global where clauses When we're merging one (or more) global where clauses in the presence of no other candidates, ensure that we return `TraitGoalProvenVia::ParamEnv` so that rigid projections work correctly. This fixes some tests with `feature(trivial_bounds)`. Fixes rust-lang#139408
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're merging one (or more) global where clauses in the presence of no other candidates, ensure that we return
TraitGoalProvenVia::ParamEnvso that rigid projections work correctly. This fixes some tests withfeature(trivial_bounds).Fixes #139408