Skip to content

Conversation

compiler-errors
Copy link
Member

See description in test.

Fixes #141119

r? lcnr

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 17, 2025
@compiler-errors compiler-errors marked this pull request as ready for review May 17, 2025 12:10
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2025
@lcnr
Copy link
Contributor

lcnr commented May 17, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 9578b59 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2025
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#135808 (Implement Display for ``rustc_target::callconv::Conv``)
 - rust-lang#137432 (Add as_ascii_unchecked() methods to char, u8, and str)
 - rust-lang#139103 (deduplicate abort implementations)
 - rust-lang#140917 (checktools.sh: fix bashism)
 - rust-lang#141035 (turn lld warning on old gccs into info log)
 - rust-lang#141118 (Enable rust-analyzer to go from query definition to the corresponding provider field)
 - rust-lang#141121 (Only select true errors in `impossible_predicates`)
 - rust-lang#141125 (check coroutines with `TypingMode::Borrowck` to avoid cyclic reasoning)
 - rust-lang#141131 (Make some `match`es slightly more ergonomic in `librustdoc`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 616650b into rust-lang:master May 17, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 17, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2025
Rollup merge of rust-lang#141121 - compiler-errors:ambig-is-not-err, r=lcnr

Only select true errors in `impossible_predicates`

See description in test.

Fixes rust-lang#141119

r? lcnr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault due to impossible_predicates treating ambiguous obligation as impossible
4 participants