Skip to content

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented May 21, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 21, 2025

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr, @compiler-errors

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 21, 2025

📌 Commit 688df6c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-cloud-vms rust-cloud-vms bot force-pushed the coerce-nested-obligations branch from 688df6c to 196c3b3 Compare May 21, 2025 11:09
@lcnr
Copy link
Contributor Author

lcnr commented May 21, 2025

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented May 21, 2025

📌 Commit 196c3b3 has been approved by compiler-errors

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#141267 (only resolve top-level guard patterns' guards once)
 - rust-lang#141280 (Use Docker cache from the current repository)
 - rust-lang#141296 (Async drop fix for 'broken mir, place has deref as later projection')
 - rust-lang#141328 (When AsyncDrop impl is empty, sync drop generated in elaborator)
 - rust-lang#141332 (Do not eagerly fold consts in `normalize_param_env_or_error` if new solver)
 - rust-lang#141333 (Use `DeepRejectCtxt` in `assemble_inherent_candidates_from_param`)
 - rust-lang#141334 (eagerly check nested obligations when coercing fndefs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9fd0ab6 into rust-lang:master May 21, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2025
Rollup merge of rust-lang#141334 - lcnr:coerce-nested-obligations, r=compiler-errors

eagerly check nested obligations when coercing fndefs

fixes rust-lang/trait-system-refactor-initiative#212

r? `@compiler-errors`
@rustbot rustbot added this to the 1.89.0 milestone May 21, 2025
@lcnr lcnr deleted the coerce-nested-obligations branch May 21, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coerce fndef to ptr ignores nested alias relate
5 participants