Properly visit nested functions and closures in check_rvalues #17984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This correctly catches moves of unsized values in nested functions and closures. Closes issue #17651
|
Thanks @bkoropoff! Could you add a test case as well? |
|
Oops, slipped my mind. Done. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 13, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Sep 25, 2024
feat: Implement cast typecheck and diagnostics Fixes rust-lang#17897 and fixes rust-lang#16564 Mainly adopted from https://github.com/rust-lang/rust/blob/100fde5246bf56f22fb5cc85374dd841296fce0e/compiler/rustc_hir_typeck/src/cast.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This correctly catches moves of unsized values in nested
functions and closures.
Closes issue #17651