Remove rlibc from the distribution #18625
Merged
+1
−205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97fa0de to
292910c
Compare
To make progress on rust-lang#18585 we're paring down the distribution to theoretically "only libstd", and this commit makes progress on this by removing the rlibc crate from the distribution. The crate has now been moved into an external cargo package located in the rust lang organization [1]. This is a breaking change due to this removal, and existing crates depending on `rlibc` should use the Cargo crate instead. [1]: https://github.com/rust-lang/rlibc [breaking-change] cc rust-lang#18585
292910c to
b39f1dc
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 6, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Dec 11, 2024
fix: Fix parser getting stuck for bad asm expressions
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 18, 2025
Even when at curly braces, otherwise the parser can get stuck. This has happened in the past in rust-lang#18625, but it was just worked around instead of handling the root of the problem. Now this happened again in rust-lang#20171. IMO we can't let `err_and_bump()` not bump, that's too confusing and invites errors. We can (as I did) workaround the worse recovery instead.
ZuseZ4
pushed a commit
to ZuseZ4/rust
that referenced
this pull request
Jul 18, 2025
Even when at curly braces, otherwise the parser can get stuck. This has happened in the past in rust-lang#18625, but it was just worked around instead of handling the root of the problem. Now this happened again in rust-lang#20171. IMO we can't let `err_and_bump()` not bump, that's too confusing and invites errors. We can (as I did) workaround the worse recovery instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make progress on #18585 we're paring down the distribution to theoretically
"only libstd", and this commit makes progress on this by removing the rlibc
crate from the distribution.
The crate has now been moved into an external cargo package located in the rust
lang organization 1
cc #18585