Rollup of 4 pull requests #25285
Closed
Rollup of 4 pull requests #25285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've written a small [EditorConfig](http://editorconfig.org) file for Rust development.
… removed the with_mode copy, thanks to eddyb
The start of the last text block in references was missing, I added it.
I've written a small [EditorConfig](http://editorconfig.org) file for Rust development.
I was profiling my code again and this time AsRef<str> for String was eating up a considerable chunk of my runtime; adding the inline annotation made the program run almost twice as fast! While I was at it I also added the annotation to other implementations of AsRef as well as AsMut.
…bnik Add example for HashMap::entry()
The start of the last text block in references was missing, I added it. r? @steveklabnik
…richton Add a few diagnostic messages; part of rust-lang#24407.
…eklabnik I think there's a trivial missing word in the Mutability document. I reformatted the resulting paragraph in vim, which seems to match what the rest of the document is doing as far as word wrapping. Edit: I found another minor thing as I continued reading. P.S. I'm re-reading the docs, since so much has changed since my first read, and they've gotten even better! Nice job! r? @steveklabnik
- Successful merges: rust-lang#24948, rust-lang#25158, rust-lang#25188, rust-lang#25222, rust-lang#25239, rust-lang#25240, rust-lang#25241, rust-lang#25255, rust-lang#25257, rust-lang#25263 - Failed merges:
According to @eddyb – and my tests – the following gets rid of the ICE in issue rust-lang#25180.
|
@bors: r+ p=1 force |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
📌 Commit 2266142 has been approved by |
|
@bors: force |
|
⌛ Testing commit 2266142 with merge 904aad6... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry force |
|
⌛ Testing commit 2266142 with merge a97b680... |
|
💔 Test failed - auto-mac-32-opt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufReadExt#25280