Skip to content

Conversation

jtepe
Copy link

@jtepe jtepe commented Jan 7, 2016

len needs to be prefixed by self for this to work. That is something which trips me up all the time. It's reassuring to see that happening to seasoned Rust programmers.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jtepe
Copy link
Author

jtepe commented Jan 7, 2016

r? @gankro

@rust-highfive rust-highfive assigned Gankra and unassigned Manishearth Jan 7, 2016
@apasel422
Copy link
Contributor

@bors: r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Jan 7, 2016

📌 Commit a073100 has been approved by apasel422

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 8, 2016
…_len, r=apasel422

len needs to be prefixed by self for this to work. That is something which trips me up all the time. It's reassuring to see that happening to seasoned Rust programmers.
bors added a commit that referenced this pull request Jan 8, 2016
@bors bors merged commit a073100 into rust-lang:master Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants