Rollup of 7 pull requests #38015
Merged
Rollup of 7 pull requests #38015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the example use DoubleEndedIterator for map, like it said it would.
The `bound` argument in `std::sync::mpsc::sync:channel(bound: usize)` was not defined in the documentation.
Remove exclamation marks from the the example error descriptions: > The description [...] should not contain newlines or sentence-ending punctuation
Also, end sentence with a period.
Add missing examples to SocketAddrV6 r? @steveklabnik cc @frewsxcv
Fix two small issues in iterator docs - `collect()` is a regular method, not an adaptor (does not return an Iterator). I just randomly picked `filter` as a third common adaptor to mention instead. - Fix example in `Map`'s docs so that it uses the DoubleEndedIterator implementation
Add a tracking issue for enum_set I totally forgot this even existed!
Define `bound` argument in std::sync::mpsc::sync_channel in the documentation The `bound` argument in `std::sync::mpsc::sync:channel(bound: usize)` was not defined in the documentation.
…enkov Remove completed FIXME. rust-lang#30530
Follow our own recommendations in the examples Remove exclamation marks from the the example error descriptions: > The description [...] should not contain newlines or sentence-ending punctuation
…eGomez Document how lock 'guard' structures are created.
|
@bors r+ p=1 |
|
📌 Commit 44b926a has been approved by |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
bors
added a commit
that referenced
this pull request
Nov 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boundargument in std::sync::mpsc::sync_channel in the documentation #37978, Remove completed FIXME. #37985, Follow our own recommendations in the examples #38001, Document how lock 'guard' structures are created. #38010