Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Mar 17, 2017

This fixes #40118

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ghost
Copy link
Author

ghost commented Mar 17, 2017

r? @steveklabnik

@steveklabnik
Copy link
Member

This looks great, thanks so much!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 17, 2017

📌 Commit 50cede0 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 18, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 18, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
bors added a commit that referenced this pull request Mar 18, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 19, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 19, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 19, 2017
documented order of conversion between u32 an ipv4addr

This fixes rust-lang#40118
bors added a commit that referenced this pull request Mar 19, 2017
Rollup of 13 pull requests

- Successful merges: #40441, #40445, #40562, #40564, #40583, #40588, #40589, #40590, #40603, #40611, #40621, #40646, #40648
- Failed merges:
@bors bors merged commit 50cede0 into rust-lang:master Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear if From<Ipv4Addr> for u32 is network order or not
4 participants