Rollup of 8 pull requests #48158
Closed
Rollup of 8 pull requests #48158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the RFC, it was discussed that figuring out whether a range is empty was subtle, and thus there should be a clear and obvious way to do it. It can't just be ExactSizeIterator::is_empty (also unstable) because not all ranges are ExactSize -- not even Range<i32> or RangeInclusive<usize>.
Relevant `stdsimd` [issue](rust-lang/stdarch#318).
Work around LLVM OCAML binding installation failure Hello, I have OCaml installed on my machine, and compiling rust systematically fails when LLVM attempts installing the OCaml bindings in `/usr/lib/ocaml`, which is write-protected. Here are the logs: https://gist.github.com/roblabla/3f147914c5df627c9d97ab311ba133ad Some digging around the issue reveals: - The code that finds if OCaml is installed, and sets the bindings to be compiled/installed: https://github.com/llvm-mirror/llvm/blob/b24a45d2e9f4fc10c3f9e16172104910b38637f2/cmake/config-ix.cmake#L612 - https://github.com/llvm-mirror/llvm/blob/b24a45d2e9f4fc10c3f9e16172104910b38637f2/bindings/ocaml/llvm/CMakeLists.txt Some code that does the installation. The problem seems to be that `LLVM_OCAML_INSTALL_PATH` is set to `OCAML_STDLIB_PATH` by default, which is in `/usr/lib/ocaml`, instead of the prefix. This PR "fixes" the issue by setting `LLVM_OCAML_INSTALL_PATH` to `usr/lib/ocaml`. I haven't found a way to make LLVM not build OCaml, which would probably be a superior fix.
…sage, r=estebank Show better warning for trying to cast non-u8 scalar to char Fixes rust-lang#44201.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=9 |
|
📌 Commit 3b3ac6b has been approved by |
|
⌛ Testing commit 3b3ac6bd3575225bb8bee0a298cafe70aa055c37 with merge 25a8486d3a2728b5e7e06b66e67267f59e9abdf2... |
|
💔 Test failed - status-travis |
…=estebank Update ops range example to avoid confusion between indexes and values. Makes clearer the numbers in the range refer to indexes, not the values at those indexes.
|
@bors r+ Removed #48076 (comment). |
|
📌 Commit b4b49eb has been approved by |
|
⌛ Testing commit b4b49eb with merge 325ecf11e8c9b50ac447f7f2c970695ed567ff87... |
|
@bors retry : prioritize stable release |
bors
added a commit
that referenced
this pull request
Feb 12, 2018
|
💔 Test failed - status-travis |
|
⌛ Testing commit b4b49eb with merge fd6cde0e9eca98a34d204233efe65ce54ace6160... |
|
💔 Test failed - status-appveyor |
|
... Let's make a new one instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.