Skip to content

Conversation

nikomatsakis
Copy link
Contributor

This used to happen implicitly through the normalization function; but we now keep the param-env as is, which seems less surprising.

cc #49685

r? @eddyb

This used to happen by default as part of the normalization routine
that was being used.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2018
@eddyb
Copy link
Member

eddyb commented Apr 26, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 26, 2018

📌 Commit 86e9a7a has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2018
@eddyb eddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 26, 2018
@pietroalbini
Copy link
Member

@bors p=1

Fixes beta regression.

@bors
Copy link
Collaborator

bors commented Apr 26, 2018

⌛ Testing commit 86e9a7a with merge 7d8f0e2...

bors added a commit that referenced this pull request Apr 26, 2018
drop elaboration should reveal all

This used to happen implicitly through the normalization function; but we now keep the param-env as is, which seems less surprising.

cc #49685

r? @eddyb
@bors
Copy link
Collaborator

bors commented Apr 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 7d8f0e2 to master...

@bors bors merged commit 86e9a7a into rust-lang:master Apr 27, 2018
@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 27, 2018
bors added a commit that referenced this pull request Apr 27, 2018
[beta] More backports

* #49368: Feature gate where clauses on associated types
* #50253: drop elaboration should reveal all *(needs `beta-accepted` stamp)*

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants