Skip to content

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented Nov 22, 2018

Fixes #56135

r? @ghost

@pietroalbini pietroalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 22, 2018
@pietroalbini pietroalbini added this to the Rust 2018 Release milestone Nov 22, 2018
@pietroalbini
Copy link
Member Author

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 22, 2018

📌 Commit 01fd001 has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 22, 2018
@mark-i-m
Copy link
Member

What is @ghost? Is that a special command to the highfive bot?

@pietroalbini
Copy link
Member Author

What is @ghost? Is that a special command to the highfive bot?

Highfive crashes when you r? a person who's not in the org, and it does nothing. @ghost happens to be a reserved account, so we don't spam anyone's inbox.

@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 23, 2018
bors added a commit that referenced this pull request Nov 23, 2018
[beta] Rollup backports

* #56163: [master] Backport 1.30.1 release notes
* #56147: resolve: Fix some asserts in import validation
* #56118: Update books for Rust 2018
* #56117: resolve: Make "empty import canaries" invisible from other crates
* #56065: Replace the ICEing on const fn loops with an error
* #56143: Issue 56128 segment id ice nightly
* #56134: Fix clippy documentation links (first in #56156)

r? @ghost
@alexcrichton
Copy link
Member

This has been backported to beta so I'm going to remove this from the milestone

@alexcrichton alexcrichton removed this from the Rust 2018 Release milestone Nov 23, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Nov 23, 2018
…, r=pietroalbini

[master] Backport 1.30.1 release notes

Fixes rust-lang#56135

r? @ghost
bors added a commit that referenced this pull request Nov 23, 2018
Rollup of 14 pull requests

Successful merges:

 - #55767 (Disable some pretty-printers when gdb is rust-enabled)
 - #55838 (Fix #[cfg] for step impl on ranges)
 - #55869 (Add std::iter::unfold)
 - #55945 (Ensure that the argument to `static_assert` is a `bool`)
 - #56022 (When popping in CTFE, perform validation before jumping to next statement to have a better span for the error)
 - #56048 (Add rustc_codegen_ssa to sysroot)
 - #56091 (Fix json output in the self-profiler)
 - #56097 (Fix invalid bitcast taking bool out of a union represented as a scalar)
 - #56116 (ci: Download clang/lldb from tarballs)
 - #56120 (Add unstable Literal::subspan().)
 - #56154 (Pass additional linker flags when targeting Fuchsia)
 - #56162 (std::str Adapt documentation to reality)
 - #56163 ([master] Backport 1.30.1 release notes)
 - #56168 (Fix the tracking issue for hash_raw_entry)

Failed merges:

r? @ghost
@bors bors merged commit 01fd001 into rust-lang:master Nov 23, 2018
@pietroalbini pietroalbini deleted the 1.30.1-relnotes-master branch November 23, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants