Fix typo bug in DepGraph::try_mark_green(). #57698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellow554
reviewed
Jan 17, 2019
| @@ -600,7 +600,7 @@ impl DepGraph { | |||
| DepKind::Hir | | |||
| DepKind::HirBody | | |||
| DepKind::CrateMetadata => { | |||
| if dep_node.extract_def_id(tcx).is_none() { | |||
| if dep_dep_node.extract_def_id(tcx).is_none() { | |||
There was a problem hiding this comment.
One could argue, that the parameter name is not very well choosen :/ Maybe one should address as well in a next patch
There was a problem hiding this comment.
It might make sense to rename dep_dep_node to dep_node_of_dependency or something like that, yeah.
|
@bors r+ Do we need to backport this to beta too? |
|
📌 Commit 3884cc8 has been approved by |
|
@Zoxc probably, |
|
Yes, let's backport it. |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 18, 2019
Fix typo bug in DepGraph::try_mark_green(). r? @Zoxc Fixes rust-lang#57692.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 18, 2019
Fix typo bug in DepGraph::try_mark_green(). r? @Zoxc Fixes rust-lang#57692.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 19, 2019
Fix typo bug in DepGraph::try_mark_green(). r? @Zoxc Fixes rust-lang#57692.
bors
added a commit
that referenced
this pull request
Jan 19, 2019
Rollup of 10 pull requests Successful merges: - #57268 (Add a target option "merge-functions", and a corresponding -Z flag (works around #57356)) - #57476 (Move glob map use to query and get rid of CrateAnalysis) - #57501 (High priority resolutions for associated variants) - #57573 (Querify `entry_fn`) - #57610 (Fix nested `?` matchers) - #57634 (Remove an unused function argument) - #57653 (Make the contribution doc reference the guide more) - #57666 (Generalize `huge-enum.rs` test and expected stderr for more cross platform cases) - #57698 (Fix typo bug in DepGraph::try_mark_green().) - #57746 (Update README.md) Failed merges: r? @ghost
|
discussed at T-compiler meeting. beta-accepted. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Zoxc
Fixes #57692.