Improve the error messages for missing stability attributes #58276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
davidtwco
approved these changes
Feb 8, 2019
src/librustc/middle/stability.rs
Outdated
| _ => self.check_missing_stability(i.id, i.span) | ||
| hir::ItemKind::Mod(..) => self.check_missing_stability(i.id, i.span, "module"), | ||
|
|
||
| _ => self.check_missing_stability(i.id, i.span, "node") |
There was a problem hiding this comment.
Using i.node.descriptive_variant() might be better than specifying a name manually. Not sure if there is an equivalent for the other functions.
|
@bors r=davidtwco |
|
📌 Commit bb1eed0 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 13, 2019
…evel, r=davidtwco Improve the error messages for missing stability attributes This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 13, 2019
…evel, r=davidtwco Improve the error messages for missing stability attributes This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).
Centril
added a commit
to Centril/rust
that referenced
this pull request
Feb 13, 2019
…evel, r=davidtwco Improve the error messages for missing stability attributes This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).
bors
added a commit
that referenced
this pull request
Feb 13, 2019
Rollup of 10 pull requests Successful merges: - #58110 (libpanic_unwind => 2018) - #58167 (HirId-ify hir::BodyId) - #58202 (Ignore future deprecations in #[deprecated]) - #58272 (Cut down on number formating code size) - #58276 (Improve the error messages for missing stability attributes) - #58354 (Fix ICE and invalid filenames in MIR printing code) - #58381 (Only suggest imports if not imported.) - #58386 (Fix #54242) - #58400 (Fix rustc_driver swallowing errors when compilation is stopped) - #58420 (target/uefi: clarify documentation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the capitalisation consistent and provides more context (especially for missing top-level attributes).