Skip to content

Conversation

LukasKalbertodt
Copy link
Member

Output before:

---- foo stdout ----
Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }
thread 'foo' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', src/libtest/lib.rs:335:5

Output with this commit:

---- foo stdout ----
Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }
thread 'foo' panicked at 'the test returned a termination value with a non-zero status code (1) which indicates a failure (this most likely means your test returned an `Err(_)`)', src/libtest/lib.rs:336:9

It's still by no means perfect. But it's already way better since
there is no strange left/right 0/1 output (I regularly got confused
by that output and searched for a failing assert_eq in my code)

Output before:

    ---- foo stdout ----
    Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }
    thread 'foo' panicked at 'assertion failed: `(left == right)`
      left: `1`,
     right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', src/libtest/lib.rs:335:5

Output with this commit:

    ---- foo stdout ----
    Error: Os { code: 2, kind: NotFound, message: "No such file or directory" }
    thread 'foo' panicked at 'the test returned a termination value with a non-zero status code (1) which indicates a failure (this most likely means your test returned an `Err(_)`)', src/libtest/lib.rs:336:9

It's still by no means perfect. But it's already way better since
there is no strange left/right 0/1 output (I regularly got confused
by that output and searched for a failing `assert_eq` in my code)
@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2019
@joshtriplett
Copy link
Member

Looks great!

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 18, 2019

📌 Commit 7fbe8d5 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2019
@bors
Copy link
Collaborator

bors commented Mar 19, 2019

☔ The latest upstream changes (presumably #57842) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2019
@LukasKalbertodt
Copy link
Member Author

Well, that's awkward! The code base I wanted to contribute to was removed from the repo! 😅 oopsie

I moved the changes to this new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants