Skip to content

Conversation

estebank
Copy link
Contributor

Fix #52965.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 27, 2019
@estebank
Copy link
Contributor Author

r? @davidtwco

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once @Centril's comments are resolved, r=me.

@estebank estebank force-pushed the borrow-sugg-shorthand-field branch from 6bafb91 to b67af6a Compare March 29, 2019 03:11
@estebank estebank force-pushed the borrow-sugg-shorthand-field branch from b67af6a to 07857f7 Compare March 29, 2019 03:13
@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@estebank estebank force-pushed the borrow-sugg-shorthand-field branch from 2420173 to 9cbc640 Compare March 29, 2019 17:44
@rust-highfive

This comment has been minimized.

@estebank estebank force-pushed the borrow-sugg-shorthand-field branch from 9cbc640 to ddfa47f Compare March 29, 2019 18:13
@estebank
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Mar 29, 2019

📌 Commit ddfa47f has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 29, 2019
…d, r=davidtwco

Account for short-hand field syntax when suggesting borrow

Fix rust-lang#52965.
Centril added a commit to Centril/rust that referenced this pull request Mar 30, 2019
…d, r=davidtwco

Account for short-hand field syntax when suggesting borrow

Fix rust-lang#52965.
bors added a commit that referenced this pull request Mar 30, 2019
Rollup of 10 pull requests

Successful merges:

 - #59376 (RFC 2008: Enum Variants)
 - #59453 (Recover from parse error in tuple syntax)
 - #59455 (Account for short-hand field syntax when suggesting borrow)
 - #59499 (Fix broken download link in the armhf-gnu image)
 - #59512 (implement `AsRawFd` for stdio locks)
 - #59525 (Whitelist some rustc attrs)
 - #59528 (Improve the dbg! macro docs )
 - #59532 (In doc examples, don't ignore read/write results)
 - #59534 (rustdoc: collapse blanket impls in the same way as normal impls)
 - #59537 (Fix OnceWith docstring.)

Failed merges:

r? @ghost
@bors bors merged commit ddfa47f into rust-lang:master Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants