Uplift get_def_path from Clippy
#59779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ Eventually we want to use a diagnostic-item API like in #58070 (comment) , but in the meantime this is fine |
|
📌 Commit a2d4e85 has been approved by |
|
Oh, #39131 is a better link for that |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 8, 2019
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Apr 11, 2019
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
|
@flip1995: 🔑 Insufficient privileges: Not in reviewers |
|
Ugh, it would be great if the author of a PR could always |
This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy.
a2d4e85 to
136d66f
Compare
|
The fix was easier, than anticipated. This should test-pass again. |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 12, 2019
This fix is obsolet once rust-lang/rust#59779 and rust-lang#3926 is merged.
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 12, 2019
This fix is obsolet once rust-lang/rust#59779 and rust-lang#3926 is merged.
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 12, 2019
This fix is obsolet once rust-lang/rust#59779 and rust-lang#3926 is merged.
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 12, 2019
This fix is obsolet once rust-lang/rust#59779 and rust-lang#3926 is merged.
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Apr 12, 2019
Rustup cc rust-lang/rust#59227 (comment) This fix is obsolet once rust-lang/rust#59779 and #3926 is merged.
|
ping @Manishearth this needs to be reapproved, due to #59779 (comment) |
|
@bors r+ |
|
📌 Commit 136d66f has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 15, 2019
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
bors
added a commit
that referenced
this pull request
Apr 15, 2019
Rollup of 6 pull requests Successful merges: - #59648 (Add must_use annotations to Result::is_ok and is_err) - #59748 (Add summary and reference to Rust trademark guide) - #59779 (Uplift `get_def_path` from Clippy) - #59955 (bump stdsimd; make intra_doc_link_resolution_failure an error again; make lints more consistent) - #59978 (rustdoc: Remove default keyword from re-exported trait methods) - #59989 (Fix links to Atomic* in RELEASES.md) Failed merges: r? @ghost
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Apr 17, 2019
Use {get,match}_def_path from rustc
This is a follow up of the uplift of `{get,match}_def_path` to rustc.
~~This is blocked on rust-lang/rust#59779~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust-clippy#3926
cc #59738
This uplifts
get_def_pathfrom Clippy. This is a follow up on theimplementation of internal lints: #59316
The internal lint implementation also copied the implementation of the
AbsolutePathPrinter. To get rid of this code duplication this alsouplifts the
get_def_pathfunction from Clippy.This also renames
match_pathtomatch_def_path, as it was originallynamed in Clippy.
r? @Manishearth