Remove mutability from Def::Static
#60124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
approved these changes
Apr 20, 2019
eddyb
reviewed
Apr 20, 2019
Def::StaticDef::Static
|
Updated. |
eddyb
approved these changes
Apr 21, 2019
|
@bors r+ |
|
📌 Commit 4eb94b4 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
|
📣 Toolstate changed by #60124! Tested on commit 31a75a1. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Apr 21, 2019
Tested on commit rust-lang/rust@31a75a1. Direct link to PR: <rust-lang/rust#60124> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra). 💔 rls on linux: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
Xanewok
added a commit
to Xanewok/rust-clippy
that referenced
this pull request
Apr 21, 2019
Fixes fallout from rust-lang/rust#60124. cc rust-lang/rust#60154
Xanewok
added a commit
to Xanewok/rust-clippy
that referenced
this pull request
Apr 21, 2019
Fixes fallout from rust-lang/rust#60124. cc rust-lang/rust#60154
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Apr 21, 2019
rustup: Use newly-introduced mutability query for statics Fixes fallout from rust-lang/rust#60124. cc rust-lang/rust#60154 changelog: none
Merged
Xanewok
added a commit
to Xanewok/rust
that referenced
this pull request
Apr 21, 2019
Fixes fallout from rust-lang#60124. Closes rust-lang#60154.
bors
added a commit
that referenced
this pull request
Apr 21, 2019
Update Clippy Fixes fallout from #60124. Closes #60154. r? @oli-obk cc @matthiaskrgr
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 5, 2020
Fixes fallout from rust-lang/rust#60124. Closes #60154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querify
TyCtxt::is_static.Use
Mutabilityinstead of bool in foreign statics in AST/HIR.cc #60110
r? @eddyb