Skip to content

Conversation

varkor
Copy link
Member

@varkor varkor commented Apr 22, 2019

This wasn't done previously in #47064 (comment) as it affected too many files, but I think it's best to fix it now so that the number of files with double trailing newlines doesn't keep increasing.

r? kennytm

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2019
@rust-highfive

This comment has been minimized.

@kennytm
Copy link
Member

kennytm commented Apr 23, 2019

@bors r+ p=2

@bors
Copy link
Collaborator

bors commented Apr 23, 2019

📌 Commit f571b95 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2019
kennytm added a commit to kennytm/rust that referenced this pull request Apr 23, 2019
…, r=kennytm

Disallow double trailing newlines in tidy

This wasn't done previously in rust-lang#47064 (comment) as it affected too many files, but I think it's best to fix it now so that the number of files with double trailing newlines doesn't keep increasing.

r? kennytm
@bors
Copy link
Collaborator

bors commented Apr 23, 2019

⌛ Testing commit f571b95 with merge 0f11354...

bors added a commit that referenced this pull request Apr 23, 2019
Disallow double trailing newlines in tidy

This wasn't done previously in #47064 (comment) as it affected too many files, but I think it's best to fix it now so that the number of files with double trailing newlines doesn't keep increasing.

r? kennytm
@bors
Copy link
Collaborator

bors commented Apr 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: kennytm
Pushing 0f11354 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants