Skip to content

Dont recur infinitely from print_def_path #62503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2019
Merged

Dont recur infinitely from print_def_path #62503

merged 2 commits into from
Jul 11, 2019

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Jul 8, 2019

Fix #61711

@rust-highfive
Copy link
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 8, 2019
@pnkfelix pnkfelix added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 8, 2019
@pnkfelix
Copy link
Member Author

pnkfelix commented Jul 8, 2019 •
edited
Loading

cc @eddyb , whom I believe introduced this recursive control structure as part of removing ppaux (PR ##58140)

@eddyb
Copy link
Member

eddyb commented Jul 11, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 11, 2019

📌 Commit 4c58b29 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 11, 2019
@bors
Copy link
Collaborator

bors commented Jul 11, 2019

⌛ Testing commit 4c58b29 with merge 4bb6b4a...

bors added a commit that referenced this pull request Jul 11, 2019
@bors
Auto merge of #62503 - pnkfelix:dont-recur-infiitely-from-print-def-p…
4bb6b4a 
…ath, r=eddyb

Dont recur infinitely from print_def_path

Fix #61711
@bors
Copy link
Collaborator

bors commented Jul 11, 2019

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: eddyb
Pushing 4bb6b4a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 11, 2019
@bors bors merged commit 4c58b29 into rust-lang:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eddyb eddyb eddyb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@varkor varkor

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: stack overflow using imported type in Fn/FnMut across three crates
5 participants
@pnkfelix @rust-highfive @eddyb @bors @varkor