Skip to content

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Sep 21, 2019

Fix #33575, fix #44504.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2019
@estebank
Copy link
Contributor Author

cc @eddyb

@Centril
Copy link
Contributor

Centril commented Sep 21, 2019

r=me with comments addressed (if you want).

@estebank
Copy link
Contributor Author

@bors r=Centril

@bors
Copy link
Collaborator

bors commented Sep 22, 2019

📌 Commit daed674 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2019
@Centril
Copy link
Contributor

Centril commented Sep 22, 2019

r? @Centril

Centril added a commit to Centril/rust that referenced this pull request Sep 22, 2019
…tril

Propagate `types.err` in locals further to avoid spurious knock-down errors

Fix rust-lang#33575, fix rust-lang#44504.
Centril added a commit to Centril/rust that referenced this pull request Sep 22, 2019
…tril

Propagate `types.err` in locals further to avoid spurious knock-down errors

Fix rust-lang#33575, fix rust-lang#44504.
bors added a commit that referenced this pull request Sep 23, 2019
Rollup of 7 pull requests

Successful merges:

 - #64294 (Fix `Stdio::piped` example code and lint)
 - #64670 (Cleanup syntax::ext::build)
 - #64674 (Propagate `types.err` in locals further to avoid spurious knock-down errors)
 - #64676 (Parse assoc type bounds in generic params and provide custom diagnostic)
 - #64677 (remove outdated comment)
 - #64679 (Infer consts more consistently)
 - #64688 (Clarify the "since" tidy check)

Failed merges:

r? @ghost
@bors bors merged commit daed674 into rust-lang:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
5 participants