Skip to content

Conversation

ayushmishra2005
Copy link
Contributor

@ayushmishra2005 ayushmishra2005 commented Mar 9, 2020

Add long explanation for the E0628 error code
Part of #61137

r? @GuillaumeGomez

@ayushmishra2005
Copy link
Contributor Author

r? @davidtwco

@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2020
@ayushmishra2005
Copy link
Contributor Author

r? @Dylan-DPC

@ayushmishra2005
Copy link
Contributor Author

Hi @Dylan-DPC I have addressed all PR comments. Could you please review the changes? Thanks in advance.

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 14, 2020

📌 Commit c33c88b has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2020
bors added a commit that referenced this pull request Mar 16, 2020
Rollup of 7 pull requests

Successful merges:

 - #67335 (Refactor the `Qualif` trait)
 - #69122 (Backtrace Debug tweaks)
 - #69520 (Make error message clearer about creating new module)
 - #69738 (More Method -> AssocFn renaming)
 - #69867 (Add long error explanation for E0628 )
 - #69989 (resolve/hygiene: `macro_rules` are not "legacy")
 - #70036 (Make article_and_description primarily use def_kind)

Failed merges:

r? @ghost
@bors bors merged commit 8f2482b into rust-lang:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants