Skip to content

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2020
@@ -1,13 +1,17 @@
`break` or `continue` must include a label when used in the condition of a
`while` loop.
`break` or `continue` keywords were used in a `while` loop condition without a

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`break` or `continue` keywords were used in a `while` loop condition without a
`break` or `continue` keywords were used in a condition of a `while` loop without a

@GuillaumeGomez
Copy link
Member Author

Updated!

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 22, 2020

📌 Commit 985ebf2 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 22, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#71829 (Fix suggestion to borrow in struct)
 - rust-lang#72123 (Stabilize process_set_argv0 feature for Unix)
 - rust-lang#72235 (Clean up E0590 explanation)
 - rust-lang#72345 (Clean up E0593 explanation)
 - rust-lang#72376 ([self-profling] Record the cgu name when doing codegen for a module)
 - rust-lang#72399 (Add fast-path optimization for Ipv4Addr::fmt)
 - rust-lang#72435 (rustllvm: Fix warnings about unused function parameters)

Failed merges:

r? @ghost
@bors bors merged commit 02eb002 into rust-lang:master May 22, 2020
@GuillaumeGomez GuillaumeGomez deleted the cleanup-E0590 branch May 26, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants