Skip to content

Improve document for Result::as_deref(_mut) methods #73447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2020
Merged

Improve document for Result::as_deref(_mut) methods #73447

merged 1 commit into from
Jun 19, 2020

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jun 17, 2020 •
edited
Loading

cc #50264

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2020
@ratijas
Copy link
Contributor

ratijas commented Jun 17, 2020 •
edited
Loading

...

dtolnay
dtolnay requested changes Jun 17, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to do this on the tracking issue since there has been quite a bit of participation from stakeholders there.

Could you update the PR to keep just the documentation changes? We can follow up with a separate stabilization PR after FCP.

@tesuji tesuji force-pushed the stabilize-result_as_deref branch from b61ac86 to 0782aee Compare June 18, 2020 02:07
@tesuji tesuji changed the title Stabilize Result::as_deref(_mut) methods Improve document for Result::as_deref(_mut) methods Jun 18, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Jun 18, 2020

Sure. Done.

@tesuji tesuji force-pushed the stabilize-result_as_deref branch from 0782aee to 4e77214 Compare June 18, 2020 02:10
dtolnay
dtolnay approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Jun 18, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 18, 2020

📌 Commit 4e77214 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 18, 2020
@RalfJung
Rollup merge of rust-lang#73447 - lzutao:stabilize-result_as_deref, r…
e96f154 
…=dtolnay

Improve document for `Result::as_deref(_mut)` methods

cc rust-lang#50264
@RalfJung RalfJung mentioned this pull request Jun 18, 2020
Closed
@Manishearth Manishearth mentioned this pull request Jun 18, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2020
@bors
Auto merge of rust-lang#73486 - Manishearth:rollup-11iyqpc, r=Manishe…
a39c778 
…arth

Rollup of 17 pull requests

Successful merges:

 - rust-lang#70551 (Make all uses of ty::Error delay a span bug)
 - rust-lang#71338 (Expand "recursive opaque type" diagnostic)
 - rust-lang#71976 (Improve diagnostics for `let x += 1`)
 - rust-lang#72279 (add raw_ref macros)
 - rust-lang#72628 (Add tests for 'impl Default for [T; N]')
 - rust-lang#72804 (Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position)
 - rust-lang#72814 (remove visit_terminator_kind from MIR visitor)
 - rust-lang#72836 (Complete the std::time documentation to warn about the inconsistencies between OS)
 - rust-lang#72968 (Only highlight doc search results via mouseover if mouse has moved)
 - rust-lang#73034 (Export `#[inline]` fns with extern indicators)
 - rust-lang#73315 (Clean up some weird command strings)
 - rust-lang#73320 (Make new type param suggestion more targetted)
 - rust-lang#73361 (Tweak "non-primitive cast" error)
 - rust-lang#73425 (Mention functions pointers in the documentation)
 - rust-lang#73428 (Fix typo in librustc_ast docs)
 - rust-lang#73447 (Improve document for `Result::as_deref(_mut)` methods)
 - rust-lang#73476 (Added tooltip for should_panic code examples)

Failed merges:

r? @ghost
@bors bors merged commit f15b346 into rust-lang:master Jun 19, 2020
@tesuji tesuji deleted the stabilize-result_as_deref branch June 19, 2020 05:16
@ehuss ehuss mentioned this pull request Jun 20, 2020
Merged
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
6 participants
@tesuji @ratijas @dtolnay @bors @cuviper @rust-highfive