Clean up E0733 explanation #74781
Merged
Clean up E0733 explanation #74781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
reviewed
Aug 1, 2020
| @@ -1,4 +1,6 @@ | |||
| Recursion in an `async fn` requires boxing. For example, this will not compile: | |||
| An `async` function used recursion without boxing. | |||
There was a problem hiding this comment.
Suggested change
| An `async` function used recursion without boxing. | |
| An [`async`] function used recursion without boxing. | |
| [`async`]: https://doc.rust-lang.org/std/keyword.async.html |
| @@ -8,8 +10,8 @@ async fn foo(n: usize) { | |||
| } | |||
| ``` | |||
|
|
|||
| To achieve async recursion, the `async fn` needs to be desugared | |||
| such that the `Future` is explicit in the return type: | |||
| To achieve async recursion, the `async fn` needs to be desugared such that the | |||
There was a problem hiding this comment.
Suggested change
| To achieve async recursion, the `async fn` needs to be desugared such that the | |
| To perform async recursion, the `async fn` needs to be desugared such that the |
|
@jyn514 I assume that it's because of the stack but honestly, I'm not really sure. |
f0b7ed3 to
507f403
Compare
|
@bors r+ rollup=always 🤷 mysteries of |
|
📌 Commit 507f403 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 2, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#74686 (BTreeMap: remove into_slices and its unsafe block) - rust-lang#74762 (BTreeMap::drain_filter should not touch the root during iteration) - rust-lang#74781 (Clean up E0733 explanation) - rust-lang#74874 (BTreeMap: define forget_type only when relevant) - rust-lang#74974 (Make tests faster in Miri) - rust-lang#75010 (Update elasticlunr-rs and ammonia transitive deps) - rust-lang#75041 (Replaced log with tracing crate) - rust-lang#75044 (Clean up E0744 explanation) - rust-lang#75054 (Rename rustc_middle::cstore::DepKind to CrateDepKind) - rust-lang#75057 (Avoid dumping rustc invocations to stdout) Failed merges: - rust-lang#74827 (Move bulk of BTreeMap::insert method down to new method on handle) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC