Skip to content

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Sep 27, 2020

I noticed this while implementing #77227 and getting a "not implemented for [T; 16]" error. There's likely more things we can deduplicate in this file, but I didn't need any additional changes.

@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 27, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Sep 27, 2020

⌛ Trying commit 455f284 with merge de1a786a9fd02c206c4260cabc6adf2a40b8d7d1...

@bors
Copy link
Collaborator

bors commented Sep 27, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: de1a786a9fd02c206c4260cabc6adf2a40b8d7d1 (de1a786a9fd02c206c4260cabc6adf2a40b8d7d1)

@rust-timer
Copy link
Collaborator

Queued de1a786a9fd02c206c4260cabc6adf2a40b8d7d1 with parent c9e5e6a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (de1a786a9fd02c206c4260cabc6adf2a40b8d7d1): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@oli-obk oli-obk closed this Sep 28, 2020
@RalfJung
Copy link
Member

Since this seems good in terms of perf, why not land it? Looks like a reasonable PR to me (without actually knowing all that code^^)

@oli-obk oli-obk reopened this Sep 28, 2020
@oli-obk
Copy link
Contributor Author

oli-obk commented Sep 28, 2020

github reviewer suggestions say

r? @matthewjasper

@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 28, 2020

📌 Commit 455f284 has been approved by matthewjasper

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 28, 2020
@bors
Copy link
Collaborator

bors commented Sep 28, 2020

⌛ Testing commit 455f284 with merge 96555ba...

@bors
Copy link
Collaborator

bors commented Sep 28, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: matthewjasper
Pushing 96555ba to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2020
@bors bors merged commit 96555ba into rust-lang:master Sep 28, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 28, 2020
@oli-obk oli-obk deleted the const_generic_array_serializer branch September 28, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants