Move f64::NAN ui tests into library
#78425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The automated code formatting check is failing because of the 2-space indentation. Can you apply the formatting suggested by rustfmt (4-space indentation)? |
jyn514
reviewed
Nov 4, 2020
library/core/tests/num/nan.rs
Outdated
Comment on lines
3
to
7
| use core::f64; | ||
| let x = "NaN".to_string(); | ||
| assert_eq!(format!("{}", f64::NAN), x); | ||
| assert_eq!(format!("{:e}", f64::NAN), x); | ||
| assert_eq!(format!("{:E}", f64::NAN), x); |
There was a problem hiding this comment.
Suggested change
| use core::f64; | |
| let x = "NaN".to_string(); | |
| assert_eq!(format!("{}", f64::NAN), x); | |
| assert_eq!(format!("{:e}", f64::NAN), x); | |
| assert_eq!(format!("{:E}", f64::NAN), x); | |
| use core::f64; | |
| let x = "NaN".to_string(); | |
| assert_eq!(format!("{}", f64::NAN), x); | |
| assert_eq!(format!("{:e}", f64::NAN), x); | |
| assert_eq!(format!("{:E}", f64::NAN), x); |
|
r? @jyn514 |
|
@bors r+ rollup |
|
📌 Commit 97d5a1b has been approved by |
|
Thanks for the PR! |
|
Will this test actually be run? Doesn't it need |
|
Oops, good catch! @bors r- |
|
@bors r+ rollup |
|
📌 Commit f9b139f has been approved by |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 5, 2020
Move f64::NAN ui tests into `library` This is a partial fix of rust-lang#76268. r? `@matklad`
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Nov 5, 2020
Move f64::NAN ui tests into `library` This is a partial fix of rust-lang#76268. r? ``@matklad``
This was referenced Nov 5, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 5, 2020
Rollup of 15 pull requests Successful merges: - rust-lang#76718 (Move Vec UI tests to unit tests when possible) - rust-lang#78093 (Clean up docs for 'as' keyword) - rust-lang#78425 (Move f64::NAN ui tests into `library`) - rust-lang#78465 (Change as_str → to_string in proc_macro::Ident::span() docs) - rust-lang#78584 (Add keyboard handling to the theme picker menu) - rust-lang#78716 (Array trait impl comment/doc fixes) - rust-lang#78727 ((rustdoc) fix test for trait impl display) - rust-lang#78733 (fix a couple of clippy warnings:) - rust-lang#78735 (Simplify the implementation of `get_mut` (no unsafe)) - rust-lang#78738 (Move range in ui test to ops test in library/core) - rust-lang#78739 (Fix ICE on type error in async function) - rust-lang#78742 (make intern_const_alloc_recursive return error) - rust-lang#78756 (Update cargo) - rust-lang#78757 (Improve and clean up some intra-doc links) - rust-lang#78758 (Fixed typo in comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix of #76268.
r? @matklad