Skip to content

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 3, 2021

This is best reviewed a commit at a time. No particular reason for these changes, they just stood out as I was reviewing #80653 and thinking about #80379. The new test case worked before, it just wasn't tested.

r? @GuillaumeGomez

@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 3, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2021
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 4, 2021

📌 Commit 24ef945 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2021
@bors
Copy link
Collaborator

bors commented Jan 4, 2021

⌛ Testing commit 24ef945 with merge 6163bfd...

@bors
Copy link
Collaborator

bors commented Jan 4, 2021

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 6163bfd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2021
@bors bors merged commit 6163bfd into rust-lang:master Jan 4, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 4, 2021
@jyn514 jyn514 deleted the duplicate-types branch January 4, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants