Skip to content

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Jan 5, 2021

This is #77604 revived.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 5, 2021
@rust-log-analyzer

This comment has been minimized.

@tesuji tesuji force-pushed the target-enumerate branch 3 times, most recently from 6eb8263 to 850fac7 Compare January 5, 2021 13:16
@petrochenkov
Copy link
Contributor

If you're still not satisfied with that respond, I will remove them.

Yes, could you remove them.
Otherwise, LGTM.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2021
@tesuji
Copy link
Contributor Author

tesuji commented Jan 6, 2021

I removed the micro methods.
@rustbot label: -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 6, 2021
@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Jan 6, 2021

📌 Commit 8ee804d has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2021
@bors
Copy link
Collaborator

bors commented Jan 6, 2021

⌛ Testing commit 8ee804d with merge 7e62e32b79236a0f7199354000afba0836e4deba...

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Build completed successfully in 0:00:55
+ /scripts/validate-toolstate.sh
Cloning into 'rust-toolstate'...
<Nothing changed>
error: book maintainer @carols10cents is not assignable in the rust-lang/rust repo

  To be assignable, a person needs to be explicitly listed as a
  collaborator in the repository settings. The simple way to
  fix this is to ask someone with 'admin' privileges on the repo
  to add the person or whole team as a collaborator with 'read'
  privileges. Those privileges don't grant any extra permissions
  so it's safe to apply them.
The build will fail due to this.

@bors
Copy link
Collaborator

bors commented Jan 6, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 6, 2021
@petrochenkov
Copy link
Contributor

error: book maintainer @carols10cents is not assignable in the rust-lang/rust repo

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 7, 2021
…nkov

Limit target endian to an enum instead of free string

This is rust-lang#77604 revived.
@bors
Copy link
Collaborator

bors commented Jan 7, 2021

⌛ Testing commit 8ee804d with merge e02b0f4...

@bors
Copy link
Collaborator

bors commented Jan 8, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing e02b0f4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 8, 2021
@bors bors merged commit e02b0f4 into rust-lang:master Jan 8, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 8, 2021
@bors bors mentioned this pull request Jan 8, 2021
@tesuji tesuji deleted the target-enumerate branch January 8, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants