Skip to content

rustdoc: Give a more accurate span for anchor failures #84203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2021
Merged

rustdoc: Give a more accurate span for anchor failures #84203

merged 1 commit into from
Apr 17, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 14, 2021

r? @euclio

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-diagnostics Area: Messages for errors, warnings, and lints A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2021
@bors

This comment has been minimized.

Sign in to view
euclio
euclio reviewed Apr 17, 2021
View reviewed changes
@euclio
Copy link
Contributor

euclio commented Apr 17, 2021

I don't have bors privileges, but LGTM.

@jyn514
Copy link
Member Author

jyn514 commented Apr 17, 2021

Thanks for the review!

@bors r=euclio

@bors
Copy link
Collaborator

bors commented Apr 17, 2021

📌 Commit 59546ef has been approved by euclio

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2021
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 17, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2021
@bors
Auto merge of rust-lang#84279 - Dylan-DPC:rollup-k7otd7e, r=Dylan-DPC
392ba2b 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#83237 (rustdoc: use more precise relative URLs)
 - rust-lang#84150 (rustdoc: move some search code into search.js)
 - rust-lang#84203 (rustdoc: Give a more accurate span for anchor failures)
 - rust-lang#84257 (Add documentation to help people find `Ipv4Addr::UNSPECIFIED`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d919a5a into rust-lang:master Apr 17, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 17, 2021
@jyn514 jyn514 deleted the anchor-span branch April 18, 2021 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@euclio euclio euclio left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jyn514 @bors @euclio @rustbot