Fix empty dom toggle #84616
Merged
Fix empty dom toggle #84616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice fix! Thanks for doing it. @bors r+ |
|
📌 Commit 9051d40 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2021
Rollup of 5 pull requests Successful merges: - rust-lang#84529 (Improve coverage spans for chained function calls) - rust-lang#84616 (Fix empty dom toggle) - rust-lang#84622 (Make traits with GATs not object safe) - rust-lang#84624 (Make sentence in env::args_os' docs plain and simple) - rust-lang#84642 (Stabilize vec_extend_from_within) Failed merges: - rust-lang#84636 (rustdoc: change aliases attribute to data-aliases) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the empty impl blocks have toggles:
So when you expand it, nothing happens:
So now, in case the impl block is empty, we simply don't generate the details/summary wrapping (which also makes DOM lighter, yeay!):
r? @jsha