Skip to content

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented May 11, 2021

Similar to #85218

@rust-highfive
Copy link
Contributor

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2021
@kornelski kornelski changed the title #[inline(always)] on basic range and slice methods #[inline(always)] on forwarding slice/vec methods May 12, 2021
@rust-timer
Copy link
Collaborator

Insufficient permissions to issue commands to rust-timer.

@bors
Copy link
Collaborator

bors commented May 12, 2021

@kornelski: 🔑 Insufficient privileges: not in try users

@rust-timer
Copy link
Collaborator

Insufficient permissions to issue commands to rust-timer.

@Xanewok
Copy link
Member

Xanewok commented May 12, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 12, 2021
@bors
Copy link
Collaborator

bors commented May 12, 2021

⌛ Trying commit f4cf82d with merge b29ffaa953e639231b99078ce39e67382e0a909b...

@bors
Copy link
Collaborator

bors commented May 12, 2021

☀️ Try build successful - checks-actions
Build commit: b29ffaa953e639231b99078ce39e67382e0a909b (b29ffaa953e639231b99078ce39e67382e0a909b)

@rust-timer
Copy link
Collaborator

Queued b29ffaa953e639231b99078ce39e67382e0a909b with parent e1ff91f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b29ffaa953e639231b99078ce39e67382e0a909b): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 12, 2021
@kornelski
Copy link
Contributor Author

It has up to 3.7% impact on compile time, ugh.

@kornelski kornelski closed this May 13, 2021
@kornelski kornelski deleted the inlinecore branch May 13, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants