Skip to content

Conversation

scottmcm
Copy link
Member

Closes #46871

r? @yaahc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2021
@yaahc
Copy link
Member

yaahc commented May 19, 2021

sick, was confused for a bit then I realized I missed a PR, #84767

@rust-log-analyzer

This comment has been minimized.

@scottmcm scottmcm force-pushed the more-try-bootstrap branch from a586b2b to 58a85d5 Compare May 19, 2021 20:32
@yaahc
Copy link
Member

yaahc commented May 20, 2021

shippit?

@bors r+

@bors
Copy link
Collaborator

bors commented May 20, 2021

📌 Commit 58a85d5 has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2021
@bors
Copy link
Collaborator

bors commented May 21, 2021

⌛ Testing commit 58a85d5 with merge af2ed1b...

@bors
Copy link
Collaborator

bors commented May 21, 2021

☀️ Test successful - checks-actions
Approved by: yaahc
Pushing af2ed1b to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why havn't implemented Error trait for std::option::NoneError ?
6 participants