Remove unnecessary structhead parameter from render_union
#87464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`structhead` is used for `render_struct` so that the logic for rendering structs can be shared between struct variants and struct items. However, `render_union` is not used anywhere except for rendering union items, so its `structhead` parameter is unnecessary.
|
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
|
r? @jyn514 |
|
📌 Commit dbb978a has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 26, 2021
…laumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#87436 (Suggest `;` on parse error where applicable) - rust-lang#87444 (Flatten nested `format!` calls) - rust-lang#87447 (Miri: santiy check that null pointer can never have an AllocId) - rust-lang#87457 (freebsd remove compiler workaround.) - rust-lang#87458 (Fix help message for modification to &T created by &{t}) - rust-lang#87464 (Remove unnecessary `structhead` parameter from `render_union`) - rust-lang#87473 (Notify the Rust 2021 edition working group in zulip of edition bugs) - rust-lang#87474 (Add missing whitespace after attribute in HTML template) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
structheadis used forrender_structso that the logic for renderingstructs can be shared between struct variants and struct items. However,
render_unionis not used anywhere except for rendering union items, soits
structheadparameter is unnecessary.