Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Nov 1, 2021

Thought this was a nice addition.

@rust-highfive
Copy link
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2021
@ghost ghost changed the title Mention remove in swap_remove Mention Vec::remove in [Vec::swap_remove](https://doc.rust-lang.org/std/vec/struct.Vec.html#method.swap_remove) Nov 1, 2021
@ghost ghost changed the title Mention Vec::remove in [Vec::swap_remove](https://doc.rust-lang.org/std/vec/struct.Vec.html#method.swap_remove) Mention Vec::remove in Vec::swap_remove Nov 1, 2021
@ghost ghost changed the title Mention Vec::remove in Vec::swap_remove Mention Vec::remove in Vec::swap_remove's docs Nov 1, 2021
@apiraino apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 11, 2021
@kennytm
Copy link
Member

kennytm commented Nov 17, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 17, 2021

📌 Commit 5f6cfd2 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 18, 2021
Mention `Vec::remove` in `Vec::swap_remove`'s docs

Thought this was a nice addition.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
Mention `Vec::remove` in `Vec::swap_remove`'s docs

Thought this was a nice addition.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
Mention `Vec::remove` in `Vec::swap_remove`'s docs

Thought this was a nice addition.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#90386 (Add `-Zassert-incr-state` to assert state of incremental cache)
 - rust-lang#90438 (Clean up mess for --show-coverage documentation)
 - rust-lang#90480 (Mention `Vec::remove` in `Vec::swap_remove`'s docs)
 - rust-lang#90607 (Make slice->str conversion and related functions `const`)
 - rust-lang#90750 (rustdoc: Replace where-bounded Clean impl with simple function)
 - rust-lang#90895 (require full validity when determining the discriminant of a value)
 - rust-lang#90989 (Avoid suggesting literal formatting that turns into member access)
 - rust-lang#91002 (rustc: Remove `#[rustc_synthetic]`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3e97d9b into rust-lang:master Nov 18, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants